Add IsDeadlockError #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giorgi
requested changes
Aug 22, 2025
DbExceptionClassifier/PostgreSQL/PostgreSQLExceptionClassifier.cs
Outdated
Show resolved
Hide resolved
Owner
|
@pengweiqhca Can you fix the failing tests too? |
There was a problem hiding this comment.
Pull Request Overview
This PR adds deadlock detection and handling capabilities to the EntityFramework.Exceptions library. The changes introduce a new DeadlockException type and implement deadlock error classification across multiple database providers.
- Adds
DeadlockExceptionclass with standard constructors for Entity Framework integration - Implements
IsDeadlockErrormethod across database-specific exception classifiers (SQL Server, PostgreSQL, Oracle, MySQL) - Adds comprehensive test coverage with database-specific test overrides for platforms that don't support deadlock testing
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| EntityFramework.Exceptions/Common/Exceptions.cs | Defines the new DeadlockException class with standard EF constructors |
| EntityFramework.Exceptions/Common/ExceptionProcessorInterceptor.cs | Adds deadlock detection to the exception processing pipeline |
| EntityFramework.Exceptions/Common/ExceptionFactory.cs | Maps deadlock database errors to DeadlockException instances |
| DbExceptionClassifier/Common/IDbExceptionClassifier.cs | Adds IsDeadlockError interface method with default implementation |
| DbExceptionClassifier/*/ExceptionClassifier.cs | Implements deadlock error detection for each database provider |
| EntityFramework.Exceptions/Tests/DatabaseTests.cs | Adds deadlock test case and exposes Options property in DemoContext |
| EntityFramework.Exceptions/Tests/*Tests.cs | Overrides deadlock test for SQLite and Oracle with skip attributes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Owner
|
@pengweiqhca Are you sure there is no way to cause deadlock in Oracle and SQLite? |
Author
|
SQLite does not have deadlocks. In Oracle, I was unable to reproduce a deadlock in the same scenario, even after waiting until timeout, so I skipped it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #88